🐛 Envtest conversion mods should set strategy and review versions #1531
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conversion webhooks require the strategy to be set and all the supported
review versions.
This change also fixes an issue where the CABundle wasn't previously
base64 encoded.
Related: Need to spend some time to make sure the whole conversion webhooks are properly tested and run correctly within envtest. I'll wait for the 1.20 refactor that @DirectXMan12 is working on.